# Stop action not working or being confused

**URL:** https://www.finalbuilder.com/forums/t/stop-action-not-working-or-being-confused/5943
**Category:** Bugs
**Created:** [December 9, 2014, 9:49am UTC](https://www.finalbuilder.com/forums/t/stop-action-not-working-or-being-confused/5943 "2014-12-09T09:49:18Z")
**Posts on this page:** 4
**Page:** 1

<div class="post-metadata">

### Author: ![catenalogic](https://www.finalbuilder.com/forums/user_avatar/www.finalbuilder.com/catenalogic/32/116_2.png) [@catenalogic](https://www.finalbuilder.com/forums/u/catenalogic)
#### Post date: [December 9, 2014, 9:49am UTC](https://www.finalbuilder.com/forums/t/stop-action-not-working-or-being-confused/5943/1 "2014-12-09T09:49:18Z")

</div>

Before upgrading to 1.5.1.41, I used the Stop action with “Build as success”. Now it looks like all of this is not working (all my CI builds are now also deploying). Basically I have this for each configuration:  
  
1) Initialize  
2) Build  
3) Test (if IsCIBuild == true, stop build as success)  
4) Create installer / deployments  
5) Deploy  
6) Finish  
  
Before the update, the software would correctly exit after 3. Now it continues after every check-in. Is there a breaking change? It looks like most of the configurations where “Stage as success” instead of “Build as success”.&nbsp;

---

<div class="post-metadata">

### Author: ![catenalogic](https://www.finalbuilder.com/forums/user_avatar/www.finalbuilder.com/catenalogic/32/116_2.png) [@catenalogic](https://www.finalbuilder.com/forums/u/catenalogic)
#### Post date: [December 9, 2014, 9:50am UTC](https://www.finalbuilder.com/forums/t/stop-action-not-working-or-being-confused/5943/2 "2014-12-09T09:50:42Z")

</div>

I just updated everything to be “Build as success” explicitly. I did this yesterday as well, but maybe I screwed something up. Will keep an eye on this.

---

<div class="post-metadata">

### Author: ![Sparky](https://www.finalbuilder.com/forums/user_avatar/www.finalbuilder.com/sparky/32/10_2.png) [@Sparky](https://www.finalbuilder.com/forums/u/Sparky)
#### Post date: [December 10, 2014, 2:17am UTC](https://www.finalbuilder.com/forums/t/stop-action-not-working-or-being-confused/5943/3 "2014-12-10T02:17:32Z")

</div>

Hi Geert,  
  
Thanks for reporting this.&nbsp;  
  
We’ve now implemented a fix and will get a new version out soon.  
  
Note that this was only happening for Stop actions which are a child of another action e.g. the If action in your case.&nbsp;We changed the options for the Stop action in the latest build to make it clearer and also added some code to migrate the old options to the new format when deserialised from the database. The code however was only running on top level actions - not child actions and we missed that in testing.

---

<div class="post-metadata">

### Author: ![catenalogic](https://www.finalbuilder.com/forums/user_avatar/www.finalbuilder.com/catenalogic/32/116_2.png) [@catenalogic](https://www.finalbuilder.com/forums/u/catenalogic)
#### Post date: [December 10, 2014, 9:30am UTC](https://www.finalbuilder.com/forums/t/stop-action-not-working-or-being-confused/5943/4 "2014-12-10T09:30:43Z")

</div>

Great support as always, thanks!
